[SeaBIOS] [PATCH 6/7] seabios: acpi: split out piix4 pm logic.
Kevin O'Connor
kevin at koconnor.net
Tue Jul 13 03:02:39 CEST 2010
On Mon, Jul 12, 2010 at 08:47:51PM +0900, Isaku Yamahata wrote:
> split out piix4 pm logic.
[...]
> @@ -202,11 +203,6 @@ static inline u16 cpu_to_le16(u16 x)
> return x;
> }
>
> -static inline u32 cpu_to_le32(u32 x)
> -{
> - return x;
> -}
This is a nitpick, but if cpu_to_le32() is moved to a header then
cpu_to_le16() needs to be moved to. It should also be moved to where
ntohl() is defined (util.h).
-Kevin
More information about the SeaBIOS
mailing list