[SeaBIOS] Alt SeaBIOS SSDT cpu hotplug

[Liu, Jinsong]

Liu, Jinsong wrote:
> Kevin O'Connor wrote:
>> On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote:
>>> Kevin O'Connor wrote:
>>>> On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote:
>>>>> Avi Kivity wrote:
>>>>>> Very nice.  I thought about doing this but abandoned it as
>>>>>> unmaintainable.  Using external functions and the ID variable,
>>>>>> however, reduces the mess to tolerable proportions, and gains us
>>>>>> a lot of flexibility.  We can now have any combinations of
>>>>>> sockets and installed cpus.
>>>>> 
>>>>> Agree, only 1 concern
>>>>> will it bring debugable/ scalable issue by hardcode aml code?
>>>> 
>>>> I've updated the patch (see below).  This version documents how one
>>>> can build a new version of the Processor() ssdt snippet.
>>>> 
>>>> I've tested this under linux - there were a few bugs in the
>>>> previous patch.  I also had to replace the dynamically created
>>>> CPUS array with a dynamically created NTFY method - which is a bit
>>>> more complicated.
>>> 
>>> Yeah, thanks Kevin.
>>> After you done patch and draft test, our QA may do nightly test.
>> 
>> Hi Jinsong,
>> 
>> Have you had any feedback from tests?
>> 
>> Thanks,
>> -Kevin
> 
> Oh, I misunderstand.
> I originally thought our QA will test after your patch send to
> upstream, so we wait for it :) 
> 
> I will talk with our QA this week to arrange test for it.
> 
> Thanks,
> Jinsong

Kevin,

We have done test for your patch, result are:
1. For linux 2.6.32 hvm guest, it works OK, for both vcpu add and vcpu remove, and re-add, re-remove, ...
2. For Window 2008 DataCenter hvm guest, it BSOD every time, QA feedback below:
==================
[QA] We test it as following:
1 copy bios.bin to /usr/local/share/qemu/
 (BTW, we also test as your method , copy bios.bin to qemu-kvm/pc-bios, then at qemu-kvm ./configure make && make install)
2 create qemu img for Windows 2008 Datacenter
 qemu-img  create -b /share/xvs/img/Windows/ia32e_win2k8_datacenter.img  -f qow2 test.img
3 create guest
 qemu-system-x86_64  -hda test.img  -m 1024 -smp 2,maxvcpus=16
4 blueScreen
==================

BTW, attached is the latest patch I received from you.
Do you have updated version?

Thanks,
Jinsong
-------------- next part --------------
An embedded message was scrubbed...
From: Kevin O'Connor <kevin at koconnor.net>
Subject: Re: Alt SeaBIOS SSDT cpu hotplug
Date: Fri, 9 Jul 2010 13:35:07 +0800
Size: 14011
URL: <http://www.seabios.org/pipermail/seabios/attachments/20100731/b2b852e8/attachment.mht>