[SeaBIOS] Bug#678042: seabios - Please enable Xen support

[Ian Campbell]

On Tue, 2012-06-19 at 19:11 -0400, Kevin O'Connor wrote:
> On Tue, Jun 19, 2012 at 05:44:08PM +0100, Ian Campbell wrote:
> > On Tue, 2012-06-19 at 13:36 +0400, Michael Tokarev wrote:
> > > 18.06.2012 23:14, Bastian Blank wrote:
> > > > Package: seabios
> > > > Version: 1.7.0-1
> > > > Severity: wishlist
> > > >
> > > > Please enable Xen support in seabios. It will be used by the next Xen
> > > > release and maybe the version in Wheezy.
> > > 
> > > Do you know what's the outcome of this?  As far as I remember, it is just
> > > a config option, but it is not enabled by default, do you know why?
> > 
> > I seem to have made it "default n" but I don't recall why. Possibly I
> > just didn't realise that people would be building a single SeaBIOS for
> > multiple uses -- I expected that folks would build one tailored to their
> > specific usecase. Or maybe it's just a hangover from my being used to
> > Linux's policy of defaulting things like this to off...
> 
> I also don't recall why.
> 
> > > 
> > > Kevin, can you comment please?
> 
> I looked, and it seems harmless to turn it on by default.

This seems pretty simple. See below (builds, but doesn't boot on Xen due
to pre-existing problem which I need to investigate)

8<---------------------------------

>From 91d2f5005a7624a953c5c4a0160d03e03a3928ba Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell at citrix.com>
Date: Wed, 20 Jun 2012 09:41:18 +0100
Subject: [PATCH] enable Xen support by default.

Signed-off-by: Ian Campbell <ian.campbell at citrix.com>
---
 src/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index 25b2b1b..8120ff7 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -13,7 +13,7 @@ menu "General Features"
     config XEN
         depends on !COREBOOT
         bool "Build for Xen HVM"
-        default n
+        default y
         help
             Configure to be used by xen hvmloader, for a HVM guest.
 
-- 
1.7.2.5




-- 
Ian Campbell
Current Noise: White Zombie - Murder World

30 day money back guarantee minus shipping, 10% restocking charge, and 7%
cancellation charge.