[SeaBIOS] [PATCH] don't produce overly large images

Gerd Hoffmann kraxel at redhat.com
Wed Aug 28 13:10:09 CEST 2013


On Mi, 2013-08-28 at 08:51 +0100, Jan Beulich wrote:
> >>> On 28.08.13 at 09:36, Gerd Hoffmann <kraxel at redhat.com> wrote:
> > Explicitly specifying the size would solve this.  You can specify
> > size=128k then and the build will fail if it doesn't fit.
> 
> Not really nice, as there's no immediate way to address such a
> build failure.

Yes.  If it doesn't fit, then it doesn't fit.

If you are okay with the bios changing the size you can just
re-configure it with 192k, 256k or whatever you want.

If you want to keep it at a certain size for compatibility reasons,
well, then you have to figure a way to make it fit.  Other compiler,
turn off features, whatever.  Might not be obvious indeed.  But there is
no magic way around it.

And as long as software can't read our minds I prefer to explicitly
configure things the way I wanna have them rather than software guessing
and getting it wrong.

> - that was the fundamental issue I ran into: Knowing nothing
> about it, I had this strange runtime failure [which admittedly is
> even worse than a build time one], and had to inspect stuff I
> should never have had a need to look at).

And your patch fixes the mentioned runtime failure?  Previous message
sounded like the patch was purely cosmetic ...

If it fixes a failure, care to explain?  That information belongs into
the commit log.

thanks,
  Gerd





More information about the SeaBIOS mailing list