[SeaBIOS] [PATCH] make qemu_cfg_init depend on QEMU_HARDWARE instead of QEMU
Kevin O'Connor
kevin at koconnor.net
Thu Jun 13 03:48:21 CEST 2013
On Wed, Jun 05, 2013 at 10:24:53AM +0200, Gerd Hoffmann wrote:
> Gets qemu features like direct kernel boot and boot
> ordering going when seabios runs on coreboot.
>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
> src/paravirt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/paravirt.c b/src/paravirt.c
> index d87a5e1..5793724 100644
> --- a/src/paravirt.c
> +++ b/src/paravirt.c
> @@ -303,7 +303,7 @@ struct QemuCfgFile {
>
> void qemu_cfg_init(void)
> {
> - if (!CONFIG_QEMU)
> + if (!CONFIG_QEMU_HARDWARE || !runningOnQEMU())
> return;
Ahh - I remembered why I didn't think this would work. The
qemu_cfg_init() function calls qemu_cfg_legacy() which will setup e820
entries, and setup smbios/acpi. I don't think those should be mixed
with the stuff that coreboot provides. I think ultimately either
seabios should pull it all from coreboot or all from qemu, but not mix
the two.
-Kevin
More information about the SeaBIOS
mailing list