[SeaBIOS] [PATCH v2] config: allow CONSOLE_IO for !QEMU
Laszlo Ersek
lersek at redhat.com
Wed May 29 14:37:27 CEST 2013
On 05/29/13 14:03, Gerd Hoffmann wrote:
> Allow selecting CONSOLE_IO for non-qemu configurations, which is useful
> when running coreboot+seabios on coreboot.
>
> [ v2: QEMU_HARDWARE is even better as CONSOLE_IO default value ]
ITYM s/DEBUG_IO/CONSOLE_IO/
Furthermore, I think we discussed something like this before, when David
& Kevin were working on the CSM stuff...
See the DEBUG_IO changes / discussion in:
http://thread.gmane.org/gmane.comp.bios.coreboot.seabios/5421/focus=5418
http://thread.gmane.org/gmane.comp.bios.coreboot.seabios/5453/focus=5457
http://thread.gmane.org/gmane.comp.bios.coreboot.seabios/5453/focus=5504
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
> src/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/Kconfig b/src/Kconfig
> index 3c80132..2695017 100644
> --- a/src/Kconfig
> +++ b/src/Kconfig
> @@ -425,9 +425,9 @@ menu "Debugging"
> Base port for serial - generally 0x3f8, 0x2f8, 0x3e8, or 0x2e8.
>
> config DEBUG_IO
> - depends on QEMU && DEBUG_LEVEL != 0
> + depends on DEBUG_LEVEL != 0
> bool "Special IO port debugging"
> - default y
> + default QEMU_HARDWARE
> help
> Some emulators or hypervisors provide with a way to output debug
> information by outputing strings in a special port present in the
>
As can be deduced from my quoted words under the third link above (and
my next message in that thread), I'm all for making DEBUG_IO as flexible
as possible -- if I understand the current Kconfig right, the CONFIG_CSM
build target still conflicts with CONFIG_DEBUG_IO, and this patch would
fix that for me. Kevin will decide of course, but personally:
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Thanks,
Laszlo
More information about the SeaBIOS
mailing list