[SeaBIOS] [PATCH] ehci: Fix bug in hub port assignment

Kevin O'Connor kevin at koconnor.net
Tue Sep 16 17:19:17 CEST 2014


On Fri, Sep 12, 2014 at 12:10:49PM -0400, Kevin O'Connor wrote:
> The usbdev->port field is zero indexed, while the USB spec expects the
> port values to start at one.
> 
> Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
> ---
> 
> This problem was causing intermittent detection failures with low
> speed devices on my c720.  It seems that most hubs don't care about
> this field, as the code has never been correct but it hasn't shown up
> as a problem prior to now.  (And even on the c720, it would still work
> much of the time.)
> 
> This patch is also available for testing at:
>   https://github.com/KevinOConnor/seabios/tree/testing

FYI, I have pushed this change along with the two other USB patch
series to master.

-Kevin



More information about the SeaBIOS mailing list