[SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration
Kevin O'Connor
kevin at koconnor.net
Sun Dec 20 20:43:23 CET 2015
On Mon, Nov 30, 2015 at 06:18:27AM +0100, Peter Stuge wrote:
> Sorry, should have sent all in one email.
>
> Stefan Berger wrote:
> > + if (enable)
> > + dprintf(DEBUG_tcg, "Return code from TPM_PhysicalEnable = 0x%08x\n",
> > + *returnCode);
> > + else
> > + dprintf(DEBUG_tcg, "Return code from TPM_PhysicalDisable = 0x%08x\n",
> > + *returnCode);
>
> Maybe simplify this to one string with %s + enable ? "Enable" : "Disable" ?
[...]
FYI, I agree with the idea of simplifying the error messages, but I
didn't think it was worth it to hold the series up.
-Kevin
More information about the SeaBIOS
mailing list