[SeaBIOS] [PATCH 08/10] tpm: Introduce tpm_get_capability() helper function
Kevin O'Connor
kevin at koconnor.net
Wed Dec 30 05:30:13 CET 2015
On Tue, Dec 29, 2015 at 09:09:09PM -0500, Stefan Berger wrote:
> On 12/29/2015 07:17 PM, Kevin O'Connor wrote:
> >+static int
> >+tpm_get_capability(u32 cap, u32 subcap, struct tpm_rsp_header *rsp, u32 rsize)
> >+{
> >+ struct tpm_req_getcap trgc = {
> >+ .hdr.tag = cpu_to_be16(TPM_TAG_RQU_CMD),
> >+ .hdr.totlen = cpu_to_be32(sizeof(trgc)),
> >+ .hdr.ordinal = cpu_to_be32(TPM_ORD_GetCapability),
> >+ .capArea = cpu_to_be32(cap),
> >+ .subCapSize = cpu_to_be32(sizeof(trgc.subCap)),
> >+ .subCap = cpu_to_be32(subcap)
> >+ };
> >+ u32 resp_size = rsize;
> >+ u32 rc = tpmhw_transmit(0, &trgc.hdr, &rsp, &resp_size,
> >+ TPM_DURATION_TYPE_SHORT);
>
> Bug: &rsp -> rsp !
>
> Otherwise it looks good.
Oops - thanks. I fixed locally.
-Kevin
More information about the SeaBIOS
mailing list