[SeaBIOS] [PATCH] coreboot: update memory table before handling execution to payload/system

Kevin O'Connor kevin at koconnor.net
Sat Nov 10 19:18:54 CET 2018


On Mon, Nov 05, 2018 at 01:27:10PM +0100, Krystian Hebel wrote:
> SeaBIOS modifies its internal e820 structure, but does not propagate
> these changes back to coreboot tables. This resulted in multiple errors
> in MemTest86 when run on 2 GB platforms, probably because of some
> memory-mapped devices.
> 
> This patch copies back modified e820 tables before booting an OS or
> a payload.

Thanks, but I'm not sure that at a "high level" this is a good idea.
I don't think SeaBIOS should be altering coreboot information.  (Doing
so leads to all sorts of painful debugging problems, for example.)  If
memtest86 is having problems with the coreboot tables I suspect it
would be best to alter memtest86 to not read the coreboot tables.

-Kevin



More information about the SeaBIOS mailing list