<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 7, 2013 at 10:40 AM, Paul Menzel <span dir="ltr"><<a href="mailto:paulepanter@users.sourceforge.net" target="_blank">paulepanter@users.sourceforge.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Dear Evgeny,<br>
<br>
<br>
thank you for the patch!<br>
<br>
<br>
Am Sonntag, den 06.10.2013, 14:14 +0300 schrieb Evgeny Budilovsky:<br>
<br>
Is this version 2 of the patch from »Sun, 6 Oct 2013 13:23:26 +0300«?<br>
Did you just remove the first Signed-off-by line? (Please mark different<br>
iterations in the subject line, like »[PATCH v3]«. See<br>
`--subject-prefix=Subject-Prefix` in `git help format-patch`.)<br>
<div><br></div></blockquote><div>Yes sorry for this. The intention was to remove the redundant signed-off stuff. I will send the next iteration using the proper prefix :) </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
> Signed-off-by: Evgeny Budilovsky <<a href="mailto:evgeny.budilovsky@ravellosystems.com" target="_blank">evgeny.budilovsky@ravellosystems.com</a>><br>
> ---<br>
> Makefile | 2 +-<br>
> src/Kconfig | 6 +<br>
> src/block.c | 1 +<br>
> src/block.h | 1 +<br>
> src/hw/blockcmd.c | 3 +<br>
> src/hw/pci_ids.h | 3 +<br>
> src/hw/pvscsi.c | 365 +++++++++++++++++++++++++++++++++++++++++++++++++++++<br>
> src/hw/pvscsi.h | 8 ++<br>
> src/post.c | 2 +<br>
> 9 files changed, 390 insertions(+), 1 deletion(-)<br>
> create mode 100644 src/hw/pvscsi.c<br>
> create mode 100644 src/hw/pvscsi.h<br>
<br>
</div>How did you test this? Does everything work?<br></blockquote><div><br></div><div>I've used windows images (win 2008/2012) taken from esx with vmware tools installed and boot disk configured to use pvscsi. </div>
<div>Also I've used linux (ubuntu 12.04) where pvscsi drivers installed by default and booted it using qemu cmd similar to this:</div><div><br></div><div>./x86_64-softmmu/qemu-system-x86_64 -snapshot -device pvscsi,id=pvscsi0 -device scsi-disk,bus=pvscsi0.0,drive=drive0 -drive id=drive0,if=none,file=ubuntu-12.04.qcow2 -bios roms/seabios/out/bios.bin<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div><br>
> diff --git a/Makefile b/Makefile<br>
> index 3218970..6c6302e 100644<br>
> --- a/Makefile<br>
> +++ b/Makefile<br>
> @@ -34,7 +34,7 @@ SRCBOTH=misc.c stacks.c output.c string.c x86.c block.c cdrom.c mouse.c kbd.c \<br>
> hw/usb-hid.c hw/usb-msc.c hw/usb-uas.c \<br>
> hw/blockcmd.c hw/floppy.c hw/ata.c hw/ahci.c hw/ramdisk.c \<br>
> hw/virtio-ring.c hw/virtio-pci.c hw/virtio-blk.c hw/virtio-scsi.c \<br>
> - hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c<br>
> + hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c hw/pvscsi.c<br>
> SRC16=$(SRCBOTH) system.c disk.c font.c<br>
> SRC32FLAT=$(SRCBOTH) post.c memmap.c malloc.c pmm.c romfile.c optionroms.c \<br>
> boot.c bootsplash.c jpeg.c bmp.c \<br>
> diff --git a/src/Kconfig b/src/Kconfig<br>
> index c40cc61..e4967d2 100644<br>
> --- a/src/Kconfig<br>
> +++ b/src/Kconfig<br>
> @@ -161,6 +161,12 @@ menu "Hardware support"<br>
> default y<br>
> help<br>
> Support boot from virtio-scsi storage.<br>
> + config PVSCSI<br>
> + depends on DRIVES && QEMU_HARDWARE<br>
> + bool "pvscsi controllers"<br>
> + default y<br>
> + help<br>
> + Support boot from pvscsi storage.<br>
<br>
</div></div>Could you at list write »Paravirtualized SCSI« out once, please? So<br>
people grepping for that can find it too. Not sure if if the<br>
abbreviation should be written all upper case like in the Wiki [1]. I do<br>
not know if that is the official spelling.<br></blockquote><div> </div><div>Yes sure sounds reasonable I will resend the changes</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
[…]<br>
<br>
<br>
Thanks,<br>
<br>
Paul<br>
<br>
<br>
[1] <a href="http://wiki.xen.org/wiki/Paravirtualized_SCSI" target="_blank">http://wiki.xen.org/wiki/Paravirtualized_SCSI</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Best Regards,<div>Evgeny</div></div>
</div></div>