<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hey Paul,<br>
<br>
<div class="moz-cite-prefix">On 6/24/2014 3:48 PM, Paul Menzel
wrote:<br>
</div>
<blockquote cite="mid:1403642902.4421.47.camel@mattotaupa"
type="cite">
<pre wrap="">Dear Matt,
Am Dienstag, den 24.06.2014, 11:48 -0500 schrieb Matt DeVillier:
</pre>
<blockquote type="cite">
<pre wrap="">Here's how I did it - this will skip the 'Press XXX for boot menu.' as
well, so that there is no delay in booting, and no confusion on the
user's part as to why the boot menu key isn't working :)
</pre>
</blockquote>
<pre wrap="">
yes, much better than my patch! Thanks!
Could you please send the patch formatted with `git format-patch -s` so
your Signed-off-by line is added too?</pre>
</blockquote>
can do<br>
<blockquote cite="mid:1403642902.4421.47.camel@mattotaupa"
type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">requires the file /etc/boot-auto to exist in the CBFS.
diff --git a/src/boot.c b/src/boot.c
index 133e206..bb5fd1f 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -455,6 +455,12 @@ interactive_bootmenu(void)
if (! CONFIG_BOOTMENU || !romfile_loadint("etc/show-boot-menu", 1))
return;
+ //skip menu if only one boot device
+ if ( NULL == BootList.first->next && romfile_loadint("etc/boot-auto", 0) ) {
</pre>
</blockquote>
<pre wrap="">
The logic seems to be reversed. The file content should be `1`,
shouldn’t it?
… && romfile_loadint("etc/boot-auto", 1)</pre>
</blockquote>
no, the 0 is the default value if the file cannot be loaded. So
logically, fail if file doesn't exist.<br>
<blockquote cite="mid:1403642902.4421.47.camel@mattotaupa"
type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">+ printf("\n");
+ return;
+ }
+
while (get_keystroke(0) >= 0)
;
</pre>
</blockquote>
<pre wrap="">
Also I wonder how I could achieve this without having to put that into
CBFS? I’d make that the default with
!romfile_loadint("etc/boot-auto", 0)
or also add a Kconfig option `AUTO_BOOT` as is done for the boot menu.</pre>
</blockquote>
I think a Kconfig option would probably be better, but I'm not set
on any one solution. The CBFS file was Kevin's suggestion/addition,
I'm running it as the default here without any override.<br>
<blockquote cite="mid:1403642902.4421.47.camel@mattotaupa"
type="cite">
<pre wrap="">
Thanks,
Paul</pre>
</blockquote>
cheers,<br>
Matt<br>
<blockquote cite="mid:1403642902.4421.47.camel@mattotaupa"
type="cite">
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SeaBIOS mailing list
<a class="moz-txt-link-abbreviated" href="mailto:SeaBIOS@seabios.org">SeaBIOS@seabios.org</a>
<a class="moz-txt-link-freetext" href="http://www.seabios.org/mailman/listinfo/seabios">http://www.seabios.org/mailman/listinfo/seabios</a></pre>
</blockquote>
<br>
</body>
</html>