[SeaBIOS] [PATCH v2 2/4] ahci: enable io/mem/dma
Kevin O'Connor
kevin at koconnor.net
Fri Dec 10 02:26:05 CET 2010
On Thu, Dec 09, 2010 at 08:39:46AM +0100, Gerd Hoffmann wrote:
> Make sure IO, MMIO and DMA are enabled in pci config space
> before using the device.
>
> [ v2: use pci_config_maskw ]
>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
> src/ahci.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/src/ahci.c b/src/ahci.c
> index ee50e8f..0b23f43 100644
> --- a/src/ahci.c
> +++ b/src/ahci.c
> @@ -436,6 +436,7 @@ ahci_init_controller(int bdf)
> {
> struct ahci_ctrl_s *ctrl = malloc_fseg(sizeof(*ctrl));
> u32 val;
> + u16 cmd;
You have an unused variable here.
The patch series looks fine to me. If there's no further comments
I'll commit this weekend.
-Kevin
More information about the SeaBIOS
mailing list