[SeaBIOS] [PATCH] vcpu hotplug: Setup vcpu add/remove infrastructure
gleb at redhat.com
Fri Jan 29 20:43:19 CET 2010
On Sat, Jan 30, 2010 at 03:22:59AM +0800, Liu, Jinsong wrote:
> >> You can update vcpu_hotplug_1.patch per your understanding.
> > I am not going to. Just not including it into seabios is my advice
> > if submitter doesn't want to address issues and read specs. I want
> > proper CPU hotplug support in seabios that works for Windows too,
> > doesn't break MS SVVP test and support arbitrary number of CPUs. The
> > code you ported from BOCHS fails on all accounts. I am OK with
> > including it as temporary solution if you address at least easy to
> > address issues, but you refuse to do even that.
> Seems you don't like to update my patch, it doesn't matter.
> Currently issue is, through discussion, I didn't quite understand what the 'ACPI NVS issue' is and what for.
> You may meet this issue before, but you didn't speak clear to make me understand.
OK. Let me try to explain it one more time. Currently MADT table resides
in memory of type "ACPI DATA" and AML code reads and writes this memory
during CPU hot-plug. According to ACPI spec "ACPI DATA" ares can be
reused by an OS, so consider what will happen if OS puts its data into
memory area where MADT was and later gets cpu hotplug event. Do you see
the problem now?
> I will go through ACPI sepc 4.0 to see if there are some clue.
> If I find what I think 'ACPI NVS issue' is, I will confirm with you to prevent any misunderstanding.
> Based on I correctly understand what you say 'ACPI NVS issue', I will then update my patch.
> This is my solution to 'ACPI NVS issue'.
More information about the SeaBIOS