[SeaBIOS] [coreboot] [PATCH] Bootsplash for SeaBIOS

Kevin O'Connor kevin at koconnor.net
Mon Jun 14 03:07:56 CEST 2010


On Mon, Jun 14, 2010 at 12:52:36AM +0200, Stefan Reinauer wrote:
> On 6/10/10 4:57 AM, Kevin O'Connor wrote:
> > One thing I did
> > note is that the new file jpeg.c needs a copyright statement.
> >   
> Still working on that.

Thanks.  I think we can commit once we have that.  (We can continue to
improve the code once committed.)

A couple of random notes:

I like the separation of the code to "vga.c".  However, I think I'd
prefer something like "bootsplash.c" over "vga.c" - just so there is
no confusion with the handle_10 vga callback implementation.

The changes to ulzma wont work.  The malloc_X calls only work in POST,
however ulzma can be called during boot (when seabios boots a
payload).  As far as I can tell it shouldn't be necessary though.
SeaBIOS has a 24K stack (at 0x7000) for the "main thread" during both
post and boot (each "thread" only has a 4K stack, but no thread calls
ulzma).

BTW, I think it should be straight forward to use this code in qemu
also.

-Kevin



More information about the SeaBIOS mailing list