[SeaBIOS] [PATCH] KVM vcpu hotplug seabios infrastructure

Liu, Jinsong jinsong.liu at intel.com
Sun Jun 20 17:40:02 CEST 2010


Kevin O'Connor wrote:
> On Wed, Jun 16, 2010 at 12:19:24PM +0800, Liu, Jinsong wrote:
>> Gleb Natapov wrote:
>>> FWIW looks good to me. This patch removes dynamic creation of
>>> Processor scope and supports only 15/255 cpus configuration, but
>>> given that new code is much more complex that old one I don't see
>>> other possibilities (unless we'll add aml compiler to seabios
>>> runtime). 
>>> 

> 
> I'm okay with the approach (two SSDTs selected by cpu count).  The
> build changes don't look right (15.c is too cryptic).  However, more
> importantly, I want to see where we end up going with the qemu/seabios
> acpi interface discussion before committing this.
> 
> -Kevin


Kevin,

Thanks for comments!

In your last comments, you prefer not to use iasl to compile seabios.
Now I update the patch as attached (only need update Makefile):
1. cancel cryptic name like 15.c from Makefile, and we give detailed description for cpu number in new version;
2. user don't need iasl again to compile seabios, except if they want to change dsdt/ssdt itself;

The process to apply patch and build in my desktop is:
$ git apply kvm-vcpu-hotplug-seabios.patch
$ git add src/acpi-ssdt.dsl
$ git add src/mk_ssdt.c
$ git add src/acpi-ssdt-15.hex
$ git add src/acpi-ssdt-anycpu.hex
$ git commit -a
$ make

We test the updated patch, it works OK with linux2.6.32 hot-add and hot-remove.

Thanks,
Jinsong
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kvm-vcpu-hotplug-seabios.patch
Type: application/octet-stream
Size: 197364 bytes
Desc: kvm-vcpu-hotplug-seabios.patch
URL: <http://www.seabios.org/pipermail/seabios/attachments/20100620/446d3ab8/attachment-0001.obj>


More information about the SeaBIOS mailing list