[SeaBIOS] [PATCH 3/3] acpi: revert d9f5cdbdf (DSDT: Fix HPET _CRS Method)

[Kevin O'Connor]

On Thu, Dec 06, 2012 at 09:42:19AM +0100, Gerd Hoffmann wrote:
> On 12/05/12 23:36, Kevin O'Connor wrote:
> > Changing the hpet resource template appears to break WinXP, so revert
> > the change.
> > 
> > Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
> > ---
> >  src/acpi-dsdt-hpet.dsl | 14 +++++++++-----
> >  1 file changed, 9 insertions(+), 5 deletions(-)
> > 
> > diff --git a/src/acpi-dsdt-hpet.dsl b/src/acpi-dsdt-hpet.dsl
> > index d5aa3f1..75b8a16 100644
> > --- a/src/acpi-dsdt-hpet.dsl
> > +++ b/src/acpi-dsdt-hpet.dsl
> > @@ -24,11 +24,15 @@ Scope(\_SB) {
> >              Return (0x0F)
> >          }
> >          Name(_CRS, ResourceTemplate() {
> > -            IRQNoFlags() {2, 8}
> 
> Kicking off this line is enougth to make winxp boot.
> 
> The irq logic in patch 2/3 works with winxp too, when booted with
> -no-hpet device manager shows irq being assigned to rtc, otherwise rtc
> has the ioports only.  So there is no conflict for IRQ 8, /me wonders
> why winxp bsods nevertheless.
> 
> I think it's better to just comment out the line and add a comment why
> it is commented out.

Feel free to send a different patch in place of this one.

If IRQ 8 isn't assigned to the HPET, is patch 2 still needed?

-Kevin